Change in vdsm[master]: stomp: reroute messages to different process

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: reroute messages to different process
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/65846/4//COMMIT_MSG
Commit Message:

Line 14: vdsm would not process it.
Line 15: 
Line 16: Once the message is processed by the client it can send a response by
Line 17: using standard engine response queue and vdsm would send it to the
Line 18: engine.
can you give an example for usage? what client needs such thing?
Line 19: 
Line 20: This mechanism allows to transparently forward messages to clients.
Line 21: 
Line 22: 


https://gerrit.ovirt.org/#/c/65846/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 245:     def _handle_internal(self, dispatcher, frame):
Line 246:         """
Line 247:         We need to build response dictionary which maps message id
Line 248:         with destination. For legacy mode we use known 3.5 destination
Line 249:         or for standard mode we use 'reply-to' header.
caught another 3.5 legacy that we can remove?
Line 250:         """
Line 251:         requests = []
Line 252:         try:
Line 253:             req_dest = frame.headers.get(stomp.Headers.REPLY_TO)


-- 
To view, visit https://gerrit.ovirt.org/65846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I622cb7f3b39a19314b7de4c325a62fa47faeaa4d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com&gt;
Gerrit-Reviewer: Stuart Gott <sgott(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes