Change in vdsm[master]: [WIP] Check move image conditions from SD data.
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Check move image conditions from SD data.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1288: def isImageMoveLegal(self, srcDom, dstDom, imgUUID):
hmmm, I am not sure about having this function in hsm.py
Line 1311: # 3) Regular image (no template based image) is always allowed
3) Move regular image ....
Anyway, I think these comments should be a part of validation function
Line 1343: # DEPRECATED
We have @deprecated
--
To view, visit http://gerrit.ovirt.org/3466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2422217717fe0f3cb668b4dc5f775e4a971c8d9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>