Igor Lvovsky has posted comments on this change.
Change subject: BZ#808116 - Fix post-zeroing process during deletion of preallocated
volumes
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File vdsm/storage/blockVolume.py
Line 706: if lv.name in lvNames:
Almost right. Should warn if lvNames has volumes that not in lvm.getLv.
But it is issue for different patch
....................................................
File vdsm/storage/hsm.py
Line 1260: vars.task.getExclusiveLock(STORAGE, imgUUID)
Right.
But it's a very dangerous patch that should be verified very carefully
--
To view, visit
http://gerrit.ovirt.org/3207
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia594ae7bea92754f25a5568e1c20a6891ff0eca5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>