Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: drop several unused local variables ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
This patch is growing too quickly and produces too frequent risks. Could you slow down or break it to sub components?
.................................................... File vdsm/storage/blockVolume.py Line 602: def newVolumeLease(cls, metaId, sdUUID, volUUID): Line 603: cls.log.debug("Initializing volume lease volUUID=%s sdUUID=%s, " Line 604: "metaId=%s", volUUID, sdUUID, metaId) Line 605: dom = sdCache.produce(sdUUID) Line 606: mdSlot = metaId ? Line 607: Line 608: leasePath = dom.getLeasesFilePath() Line 609: leaseOffset = ((mdSlot + RESERVED_LEASES) Line 610: * dom.logBlkSize * sd.LEASE_BLOCKS)