Dan Kenigsberg has posted comments on this change.
Change subject: Integrate Smartcard support
......................................................................
Patch Set 7: I would prefer that you didn't submit this
I'm sorry to spoil the party, but I'm not extremely happy about the proposed API.
We've started a big shift towards a unified API, where all guest devices are defined
in the "devices" section of the configuration.
This would allow - in the future - to control device addresses and other properties, where
a simple boolean is not enough.
Please see the balloon device for more details.
--
To view, visit
http://gerrit.ovirt.org/8450
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server