Gal Hammer has posted comments on this change.
Change subject: [RFE] Integrate Smartcard support
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 787: Add smartcard section to domain xml
Line 788:
Line 789: <smartcard mode='passthrough' type='spicevmc'/>
Line 790: """
Line 791: if self.conf.get('smartcard_enabled') == 'true':
I think you should use this style:
if utils.tobool(self.conf.get(''smartcard_enabled'', 'false'):
It is safer and include a default value.
Line 792: card = self.doc.createElement('smartcard')
Line 793: card.setAttribute('mode', 'passthrough')
Line 794: card.setAttribute('type', 'spicevmc')
Line 795: self._devices.appendChild(card)
--
To view, visit
http://gerrit.ovirt.org/8450
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>