Bala.FA has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
......................................................................
Patch Set 14:
(2 comments)
minor comments
http://gerrit.ovirt.org/#/c/35028/14//COMMIT_MSG
Commit Message:
Line 8:
Line 9: This patch adds new verb glusterStorageDevicesList
Line 10: which provides list of disks and storage devices detail.
Line 11:
Line 12: Output format is
Add what the verb returns like
{'deviceInfo': [{device_dict}, ...]}
Line 13: { 'name': DEVICE_NAME,
Line 14: 'devPath': DEVICE_PATH,
Line 15: 'devUuid': DEVICE_UUID,
Line 16: 'bus': BUS,
http://gerrit.ovirt.org/#/c/35028/14/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 34: 'fsType': '',
Line 35: 'mountPoint': '',
Line 36: 'uuid': '',
Line 37: 'createBrick': True}
Line 38: if not info['bus'] and len(device.parents) > 0:
this can be simplified by
if not info['bus'] and device.parents:
Line 39: info['bus'] = device.parents[0].bus
Line 40: if device.model:
Line 41: info['model'] = "%s (%s)" % (device.model,
device.type)
Line 42: else:
--
To view, visit
http://gerrit.ovirt.org/35028
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f520c6f476731cb5982d8256cb701387be87cf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nishanth Thomas <nishusemail(a)gmail.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes