Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add Image.getVolumeChain API
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25918/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1788: retVolumes = []
Line 1789: imageResourcesNamespace = sd.getNamespace(sdUUID, IMAGE_NAMESPACE)
Line 1790: with rmanager.acquireResource(imageResourcesNamespace, imgUUID,
Line 1791: rm.LockType.shared):
Line 1792: # TODO: Do we need to ensure that they get deactivated also?
Yes, that's a must.
Line 1793: dom.activateVolumes(imgUUID, knownVols)
Line 1794:
Line 1795: volUUID = leafVolUUID
Line 1796: while volUUID is not None:
--
To view, visit
http://gerrit.ovirt.org/25918
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e50d7292b98b5dbf1f0978efe5f0de589b3dbc0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes