Change in vdsm[master]: Always use OOP when padding snapshot's memory volume

Arik Hadas has posted comments on this change.

Change subject: Always use OOP when padding snapshot's memory volume
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26538/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: The padding is made right after libvirt dumps the memory content into
Line 10: the volume, so the volumes is accessible and writable - doing the
Line 11: padding in different process looks like an expensive operation which is
Line 12: not required in that case. Thus, all the padding will now be made
>  As I said, this is wrong. All you know is that the volume WAS
> accessible an 
yeah, I see. so how about to use OOP for all file-based storage types?
I tried to convince in the commit message of the next patch-set :)
Line 13: without OOP.
Line 14: 
Line 15: Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b


-- 
To view, visit http://gerrit.ovirt.org/26538
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes