Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62092/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-08-08 14:23:25 +0200
Line 4: Commit: Tomáš Golembiovský <tgolembi(a)redhat.com>
Line 5: CommitDate: 2016-08-09 16:21:43 +0200
Line 6:
Line 7: v2v: Add execCmd() that accepts stdin/out/err
so let's bend the rules ;)
Done
Line 8:
Line 9: There is no way to pass stdin, stdout and stderr streams to Popen via
Line 10: execCmd. This will be useful in subsequent changes introducing logging
Line 11: of virt-v2v output.
--
To view, visit
https://gerrit.ovirt.org/62092
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c748155e233ebfb2c0c223308693ccaab0ebc18
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes