Federico Simoncelli has posted comments on this change.
Change subject: Remove unnecesary preparePaths. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/clientIF.py Line 985 Removing this is wrong (at least at the moment). To speed up the recovery the current flow is:
1. Recover all the VMs objects (WaitForLaunch) 2. Clean up the repository 3. Reconnect to the pool (re-creates the missing links) 4. Wait for the re-connection to complete 5. Prepare the paths (here), at the moment just to switch _volumesPrepared to True (but we can't guarantee that in the future we'll need more things so I'd like to keep the preparePaths call) 6. Now that everything is ready we can resume the vm stats
-- To view, visit http://gerrit.ovirt.org/786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35890d36227633ca147387d670c152b9be357e50 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com