Change in vdsm[master]: Move nfsSD.getFileList into misc so it can be reused

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move nfsSD.getFileList into misc so it can be reused
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 7: Move nfsSD.getFileList into misc so it can be reused
I did not think it through, but fileSD is the natural location. misc is our trash-can of
badly-modeled code. let us try not to fill it up more.

....................................................
File vdsm/storage/misc.py
Line 175: def getFileList(self, pattern, caseSensitive):
self? with no class container? I bet this was never tested.

Line 181:     filesList = self.oop.simpleWalk(basedir)
oop is probably an overkill for localstorage. if the local disk fails on us, no one is
going to expect vdsm to continue to work.

--
To view, visit http://gerrit.ovirt.org/3937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b952669a22bd79ca6a38db5396efa63a87bc830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;