Change in vdsm[master]: profiling: Add whole application profile

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: profiling: Add whole application profile
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26113/1/vdsm/vdsm
File vdsm/vdsm:

Line 88:         if config.getboolean('vars', 'profile_enable'):
Line 89:             logging.debug("Stopping profiling")
Line 90:             yappi.stop()
Line 91:             stats = yappi.get_func_stats()
Line 92:             stats.save('/tmp/vdsmd.prof', 'pstat')
this would open the door for a symlink attack. Please use /var/run/vdsm for writing
vdsm-specific temporary data.
Line 93:     finally:
Line 94:         cif.prepareForShutdown()
Line 95: 
Line 96: 


-- 
To view, visit http://gerrit.ovirt.org/26113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I523f52c981f7bb34f3168d3117f00ed5eb6962f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes