Sahina Bose has posted comments on this change.
Change subject: virt: enable libgfapi
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44061/7/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 317:
Line 318: # The order of imgVolumesInfo is not guaranteed
Line 319: drive['volumeChain'] = res['imgVolumesInfo']
Line 320: drive['volumeInfo'] = res['info']
Line 321: if drive.get('diskType') == DISK_TYPE.NETWORK:
I tried applying this patch on master but drive.get('diskType') is None for
gluster volume.
Line 322: volinfo = res ['info']
Line 323: volPath = volinfo['path']
Line 324: drive['protocol'] = volinfo['protocol']
Line 325: # currently, single host is provided due to this bug:
--
To view, visit
https://gerrit.ovirt.org/44061
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes