Dan Kenigsberg has posted comments on this change.
Change subject: engine.py: replace sed to setVdsConf
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm_reg/engine.py.in
Line 123: "vdc_host_name=%s" % engineHost, VDSM_REG_CONFIG):
Line 124: log("The @ENGINENAME@'s address is set: %s\n" %
engineHost)
Line 125: if enginePort != "":
Line 126: if deployUtil.setVdsConf(
Line 127: "vdc_host_port=%s" % str(enginePort),
VDSM_REG_CONFIG):
I'm pretty sure that I've already commented on the redundant call to str() here.
oh well, let it wait for another patch.
Line 128: log("The @ENGINENAME@'s port set: %s\n" % enginePort)
Line 129: fWriteConfig = 1
Line 130:
Line 131: if fWriteConfig == 1:
--
To view, visit
http://gerrit.ovirt.org/12299
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a0889843feba29abbfb02f3d81293df7f2f3fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server