Ayal Baron has posted comments on this change.
Change subject: BZ#754445 - Defer grant until all resource manager locks are freed
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
After a long discussion in irc, we agreed that although the code is overly complex and
leads to errors, my suggested solution would require more acrobatics because the caller
does not have a reference to the resource, only to the request, making it complex as
well.
Long term we should get rid of the entire mechanism to reduce complexity (and solve in a
simpler way)
changing to +1
--
To view, visit
http://gerrit.ovirt.org/254
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>