Dan Kenigsberg has posted comments on this change.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/62628/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 58: requestQueue = requestQueues.split(",")[0]
Line 59: return jsonrpcvdscli.connect(requestQueue=requestQueue)
Line 60:
Line 61: config = _importVdsmPylibModule("vdsm.config").config
Line 62: dump_volume_chains =
_importVdsmPylibModule("vdsm.tool.dump_volume_chains")
do we still need this?
Line 63: jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
Line 64:
Line 65:
Line 66: class vdsm(Plugin, RedHatPlugin):
Line 149: for pool in pools_list:
Line 150: self.addObjectAsFile(
Line 151: cli.getSpmStatus(pool), "getSpmStatus " +
pool)
Line 152:
Line 153: sd_uuid, = cli.getStorageDomainsList()["items"]
I think this would explode if you have multiple storage domains in the datacenter
Line 154:
Line 155: self.collectExtOutput("vdsm-tool dump-volume-chains %s" %
sd_uuid)
Line 156:
Line 157: def _addVdsmRunDir(self):
--
To view, visit
https://gerrit.ovirt.org/62628
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes