Change in vdsm[master]: setup: move the the certificate generation

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: setup: move the the certificate generation
......................................................................


Patch Set 1: (1 inline comment)

Thanks!!!

Questions:

1. If we run on ovirt-node, shouldn't we persist?

2. I would have created all the files in temporary folder, and if all the process
succeeded move to final destination.

I don't think there is real value in partial files.

What do you think?

....................................................
File vdsm/vdsm-gencerts.sh.in
Line 115:     /sbin/restorecon "$__vdsm_gencerts_crt"
Line 116:     /bin/rm -f "$__vdsm_gencerts_template"
Line 117: }
Line 118: 
Line 119: if [ "$1" != "--bash-import" ]; then
--sh-import? :)
Line 120:     vdsm_create_key
Line 121:     vdsm_create_ca
Line 122:     vdsm_create_cert


--
To view, visit http://gerrit.ovirt.org/8368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;