Change in vdsm[master]: netinfo: Report current system values for bonding options

Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Report current system values for bonding options
......................................................................


Patch Set 51:

(1 comment)

Acked splitting the patch.

http://gerrit.ovirt.org/#/c/24456/51/vdsm/network/models.py
File vdsm/network/models.py:

Line 239
Line 240
Line 241
Line 242
Line 243
>  Sorry for noticing this only now, but this is a change of
> functionality. Un 
Until recently, it was really necessary to remove this information
because it "polluted" ifcfg files during tests so they ended up failing (in
assertBondExists).

I will split the patch hoping that the newly relaxed check in assertBondExists, which
caused the tests to fail before, now behaves well.


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 51
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes