Change in vdsm[master]: operation: Prepare for integrating CommandStream

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: operation: Prepare for integrating CommandStream
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/74618/2/lib/vdsm/storage/operation.py
File lib/vdsm/storage/operation.py:

Line 125:             self._proc = compat.CPopen(self._cmd,
Line 126:                                        cwd=self._cwd,
Line 127:                                        stdin=None,
Line 128:                                        stdout=subprocess.PIPE,
Line 129:                                        stderr=subprocess.PIPE)
putting a call to CPopen under is a lock sounds risky. under the lock you should only
change the state and release it quickly
Line 130:             self._state = RUNNING
Line 131: 
Line 132:     def _finalize(self, out, err):
Line 133:         """


-- 
To view, visit https://gerrit.ovirt.org/74618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff363e710fcdc5d6cd5843ca2239973c89a69dd3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes