Dan Kenigsberg has posted comments on this change.
Change subject: setup: move the certificate generation
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 430: python @VDSMDIR(a)/hooks.pyc before_vdsm_start
Line 431:
Line 432: shutdown_conflicting_srv && stop_libvirtd_sysv
Line 433:
Line 434: if ! vdsm_check_certificate; then
please help the future re-write of this into vdsm-tool by replacing this new code block
with something like
if ! /usr/libexec/.../vdsm-gencert.sh --check; then
echo bla
/usr/libexec/.../vdsm-gencert.sh
fi
I feel strongly against sourcing more function into this script.
Line 435: echo -n $"Configuring a self-signed VDSM host certificate: "
Line 436: (vdsm_create_key && vdsm_create_ca && vdsm_create_cert)
\
Line 437: && success || failure; echo
Line 438: fi
--
To view, visit
http://gerrit.ovirt.org/8368
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>