Darshan N has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
......................................................................
Patch Set 16:
(7 comments)
http://gerrit.ovirt.org/#/c/18414/16//COMMIT_MSG
Commit Message:
Line 15: its remote-volumes or between a specified local and remote volume.
Line 16: Returns:
Line 17: {volumeName: 'volume name',
Line 18: sessions: [{sessionKey: 'unique identification for session ',
Line 19: remoteVolume: 'name of remote volume involved in session'
How about 'remoteVolume' to 'remoteVolumeName' ?
Done
Line 20: pairs: [{host: 'local host',
Line 21: hostUuid: 'uuid of brick host',
Line 22: brickName: 'local brick',
Line 23: remotehost: 'slave',
Line 16: Returns:
Line 17: {volumeName: 'volume name',
Line 18: sessions: [{sessionKey: 'unique identification for session ',
Line 19: remoteVolume: 'name of remote volume involved in session'
Line 20: pairs: [{host: 'local host',
how about changing 'pairs' to 'bricks'?
Done
Line 21: hostUuid: 'uuid of brick host',
Line 22: brickName: 'local brick',
Line 23: remotehost: 'slave',
Line 24: status: 'status',
http://gerrit.ovirt.org/#/c/18414/16/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Line 468: remoteVolumeName)
Line 469: pp.pprint(status)
Line 470: return status['status']['code'],
status['status']['message']
Line 471:
Line 472: def do_glusterVolumeGeoRepSessionDetail(self, args):
How about glusterVolumeGeoRepSessionStatus?
Done
Line 473: params = self._eqSplit(args)
Line 474: volumeName = params.get('volumeName', '')
Line 475: remoteHost = params.get('remoteHost', '')
Line 476: remoteVolumeName = params.get('remoteVolumeName', '')
http://gerrit.ovirt.org/#/c/18414/16/vdsm/gluster/api.py
File vdsm/gluster/api.py:
Line 346: volumeName,
Line 347: remoteHost,
Line 348: remoteVolumeName
Line 349: )
Line 350: return {'geo-rep-list': status}
How about 'sessions' for 'geo-rep-list'?
Done
Line 351:
Line 352: @exportAsVerb
Line 353: def volumeGeoRepSessionDetail(self, volumeName, remoteHost,
Line 354: remoteVolumeName, options=None):
Line 356: volumeName,
Line 357: remoteHost,
Line 358: remoteVolumeName
Line 359: )
Line 360: return {'geo-rep-session-detail': status}
How about 'sessionStatus'?
Done
Line 361:
Line 362:
Line 363: def getGlusterMethods(gluster):
Line 364: l = []
http://gerrit.ovirt.org/#/c/18414/16/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1182: return status
Line 1183:
Line 1184:
Line 1185: @makePublic
Line 1186: def volumeGeoRepSessionList(volumeName=None, remoteHost=None,
Please note that this file is one-to-one with gluster cli. It means
how gl
Done
Line 1187: remoteVolumeName=None):
Line 1188: command = _getGlusterVolCmd() + ["geo-replication"]
Line 1189: if volumeName:
Line 1190: command.append(volumeName)
Line 1202:
Line 1203:
Line 1204: @makePublic
Line 1205: def volumeGeoRepSessionDetail(volumeName, remoteHost, remoteVolumeName):
Line 1206: command = _getGlusterVolCmd() + ["geo-replication", volumeName,
Please use _getGlusterVolGeoRepCmd()
Done
Line 1207: "%s::%s" % (remoteHost,
remoteVolumeName),
Line 1208: "status", "detail"]
Line 1209: try:
Line 1210: xmltree = _execGlusterXml(command)
--
To view, visit
http://gerrit.ovirt.org/18414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes