Xu He Jie has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File vdsm/supervdsmServer.py
Line 313: chown(ADDRESS, METADATA_USER, METADATA_GROUP)
This user should be same with the user which used to startup vdsm.py
....................................................
File vdsm/vdsm
Line 28: print " -h - Display this help message"
I guess you forgot change this usage message
Line 104: os.setuid(uid)
Hmm, move this to supervdsmServer? let supervdsmServer to decide which user will be used.
vdsm needn't know which user it want to use.
....................................................
File vdsm/vdsmd.init.in
Line 492: LC_ALL=C NICELEVEL=$vdsm_nice daemon @VDSMDIR@/respawn --minlifetime 10
--daemon --masterpid $RESPAWNPIDFILE $SVDSM_BIN
for fedora, respawn can be done by systemd, did you have plan for this?
--
To view, visit
http://gerrit.ovirt.org/4145
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>