Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 41: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24456/41/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1216: # See if live options (read from sysfs) match those requested
Line 1217: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
Line 1218: self.assertEqual(set(cfg['BONDING_OPTS'].split()),
Line 1219: set(bondDict['options'].split()))
Line 1220:
I'd rather have this check integrated as an optional check inside assertBondExists
Line 1221: @cleanupNet
Line 1222: @permutations([[True], [False]])
Line 1223: @RequireDummyMod
Line 1224: @ValidateRunningAsRoot
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 41
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes