Change in vdsm[master]: fencing: use deathSignal to keep scripts at bay

Yaniv Bronhaim has posted comments on this change.

Change subject: fencing: use deathSignal to keep scripts at bay
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/22997/3/vdsm/API.py
File vdsm/API.py:

Line 1150:             else:
Line 1151:                 power = 'unknown'
Line 1152:                 message = out + err
Line 1153:             return {'status': {'code': 0, 'message':
message},
Line 1154:                     'power': power}
put else please or return only at the end.. its much more readable ... don't you
agree?
Line 1155:         threading.Thread(target=fence, args=(script, inp)).start()
Line 1156:         return {'status': doneCode}
Line 1157: 
Line 1158:     def ping(self):


-- 
To view, visit http://gerrit.ovirt.org/22997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I068acf5ca0ad0813aaef660770de79958bd0b763
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes