Dan Kenigsberg has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File vdsm/rest/BindingREST.py
Line 24: def __init__(self, cif, log, params):
I agree that the same problem applies to BindingXMLRPC: python's way of passing
initially-unknown arguments is with **kwargs.
....................................................
File vdsm/rest/Controller.py
Line 52: templatePath = "%s/rest/templates" % constants.P_VDSM
cool - in case it was not clear, my point is to make the code more easily testable, and
avoid set_template_path() completely.
....................................................
File vdsm.spec.in
Line 45: Requires: python-cherrypy python-cheetah
hmm, maybe. since your code is in its own python package, it would not incur much harm if
shipped disabled. on the other hand, we do want to become more modular.
--
To view, visit
http://gerrit.ovirt.org/2021
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>