Federico Simoncelli has posted comments on this change.
Change subject: vm: _normalizeVdsmImg refactoring
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/19157/3/vdsm/vm.py
File vdsm/vm.py:
Line 2040: drive['device'] = drive.get('device', 'disk')
# Disk by default
Line 2041: drive['reqsize'] = drive.get('reqsize', '0') #
Backward compatible
Line 2042:
Line 2043: if drive['device'] == 'disk':
Line 2044: volInfo = self.cif.irs.getVolumeInfo(
I'll split this change out.
Line 2045: drive['domainID'], drive['poolID'],
drive['imageID'],
Line 2046: drive['volumeID'])
Line 2047:
Line 2048: if volInfo['status']['code'] != 0:
--
To view, visit
http://gerrit.ovirt.org/19157
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majopela(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes