Yeela Kaplan has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1831:
Line 1832: # FIXME: pathListIter() should not return empty records
Line 1833: if storageType:
Line 1834: for dev in multipath.pathListIter(guids):
Line 1835: if dev["devtype"] != storageType:
I am removing the FIXME as devtype in devinfo is initialized in pathListIter.
Line 1836: continue
Line 1837:
Line 1838: pv = pvs.get(dev.get('guid', ""))
Line 1839: if pv is not None:
--
To view, visit
http://gerrit.ovirt.org/13363
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server