Change in vdsm[master]: Refactor unit test directory structure

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Refactor unit test directory structure
......................................................................


Patch Set 2: (3 inline comments)

As noted in the commit message there's still some work to be done for python 2.6
compatibility (which I assume we want for RHEL6 compatibility).

I'm no hero with makefiles so I would like some review on in-line comments.

....................................................
File Makefile.am
Line 38: check-local: all
I need all here because I need files like config.py.in to be build. Is there a better
target?

Line 40: 	$(MAKE) -C tests $@
I wondered if you want a separate tests target or add it to check-local. Since there was
already a check-local in the previous tests/Makefile.am I chose check-local, but would
like someone else to confirm this choice.

....................................................
File tests/Makefile.am
Line 23: 	vdsm
I'm not sure I can just name a directory here or if I should name all files. It seems
to work but I'm no hero on makefiles and their standards.

--
To view, visit http://gerrit.ovirt.org/2839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5179f5c9711b3b8f353fc3ea590730059c9f3d7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;