Adam Litke has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
......................................................................
Patch Set 3:
(1 comment)
One minor schema issue but otherwise looks ok.
https://gerrit.ovirt.org/#/c/45823/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 1495: 'pathstatus': ['BlockDevicePathInfo'],
Line 1496: 'pathlist': ['IscsiSessionInfo'],
'logicalblocksize': 'uint',
Line 1497: 'physicalblocksize': 'uint', 'partitioned':
'bool',
Line 1498: 'pvsize': 'uint', 'status':
'BlockDeviceStatus',
Line 1499: 'vgname': 'str'}}
The type should be UUID.
Line 1500:
Line 1501: ##
Line 1502: # @Host.getDeviceList:
Line 1503: #
--
To view, visit
https://gerrit.ovirt.org/45823
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes