Saša Tomić has posted comments on this change.
Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File tests/alignmentScan_test.py
Line 46: cmd = "/bin/dd if=/dev/zero of=%s bs=4K count=1K" % imagepath
I believe that the function is completely safe, since I am calling it only from this
module and only with space-free filenames. Anyway, I will modify it to be a list.
....................................................
File vdsm/alignmentScan.py
Line 32: if not os.path.exists(image_path):
Done
Line 37: raise ValueError("An error scanning the disk image or
guest:\n%s" % err)
Done
Line 45: # (allows easier iteration)
Done
Line 47: out_list = [ScanOutput(*line.split(None, 3)) for line in out]
Converting only a single entry of a list to int would need several lines instead of only
one (this). If you *really* need it (i.e. have a particular functionality that you would
like to do), I can do it. Otherwise, it would simply make the code less readable and I
would avoid it. You can also convert it lazily, at the place you want to use the integer
value of the partition size.
--
To view, visit
http://gerrit.ovirt.org/2916
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saša Tomić <tomic80(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saša Tomić <tomic80(a)gmail.com>