Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: BZ#800915 - no need to support list in removeVM command
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
I think mixing plural and singular in functions violates the Principle of least
astonishment.
....................................................
File vdsm/API.py
Line 904: return self._irs.removeVM(self._UUID, vmUUID, sdUUID)
I think the name removeVMs is weird because it implies multiple VMs can be removed, but
the arguments and code suggest it can't.
....................................................
File vdsm/BindingXMLRPC.py
Line 579: return pool.removeVMs(vmUUID, sdUUID)
Same here
--
To view, visit
http://gerrit.ovirt.org/2694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a0e5848ece1aa147f4508d4d16842bcdb30af0d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>