Federico Simoncelli has posted comments on this change.
Change subject: logging: Enable all storage loggers
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/23924/1//COMMIT_MSG
Commit Message:
Line 9: Only loggers mentioned in logger.conf, or their child loggers are used
Line 10: by the logging system. This make debugging the code much harder.
Line 11:
Line 12: This patch enable 23 storage loggers by making them child loggers of the
Line 13: Storage logger.
It would be nice it they did, but it seems that they do not.
That's weird, the default behavior should be indeed to inherit from root. I
wonder if there's something that we do that breaks that system (maybe propagate=0 in
the root logger?). I think we should test our logger.conf thoroughly.
Line 14:
Line 15: If we want to disable some loggers, the proper place to do it is in
Line 16: logger.conf.
Line 17:
--
To view, visit
http://gerrit.ovirt.org/23924
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes