Change in vdsm[master]: virt: move vmxml.Domain to its own module

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: move vmxml.Domain to its own module
......................................................................


virt: move vmxml.Domain to its own module

We move vmxml.Domain into the newly introduced libvirtxml.py module.
This way we isolate the utility XML processing code from the code which
uses it to build the libvirt XML. The key benefit is that with this
patch we can reuse the utility code in the upcoming metadata handling,
module, avoiding circular dependencies.

Other lesser benefits are the slightly easier future removal of the XML
building code, and the fact that 'libvirtxml.Domain' reads a bit nicer.

Change-Id: Ie2cecd05ac50c1514045219983bac79f0ff9ec09
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M lib/vdsm/virt/Makefile.am
A lib/vdsm/virt/libvirtxml.py
M lib/vdsm/virt/vmxml.py
M lib/vdsm/virt/xmlconstants.py
M tests/hostdev_test.py
M tests/vm_test.py
M tests/vmxml_test.py
M vdsm.spec.in
M vdsm/virt/vm.py
9 files changed, 567 insertions(+), 527 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/72015
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2cecd05ac50c1514045219983bac79f0ff9ec09
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;