Nir Soffer has posted comments on this change.
Change subject: migration: coalesce join() into stop()
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62587/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 576: self._stop.set()
Line 577: if self._thread.is_alive():
Line 578: # on very short migrations, the downtime thread
Line 579: # may not be started at all.
Line 580: self._thread.join()
This is generally bad idea, making stop wait for the thread in all cases. Separating
stop() and join() will allow stopping multiple threads at once.
Line 581:
Line 582: def _set_downtime(self, downtime):
Line 583: self._vm.log.debug('setting migration downtime to %d',
downtime)
Line 584: self._vm._dom.migrateSetMaxDowntime(downtime, 0)
--
To view, visit
https://gerrit.ovirt.org/62587
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6def55d50a61ac983b45e826c05e09887fe5ee0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes