Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 50: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24456/50//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-02-07 02:56:31 +0100
Line 4: Commit: Ondřej Svoboda <osvoboda(a)redhat.com>
Line 5: CommitDate: 2014-05-20 19:23:38 +0200
Line 6:
Line 7: netinfo: Retrieve bonding options differing from defaults
the commit messsage should describe the modified output, as well as the motivation for the
change.
Line 8:
Line 9: Functional network tests were extended to check for "live" values.
Line 10:
Line 11: Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
http://gerrit.ovirt.org/#/c/24456/50/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1403:
Line 1404: self.assertBondExists(BONDING_NAME, nics[:2],
Line 1405:
bondings[BONDING_NAME].get('options'))
Line 1406: self.assertEquals(self.vdsm_net.getBondMode(BONDING_NAME),
Line 1407: REQMODE_BROADCAST) # TODO: redundant?
If you want to add a TODO, make it clear so that other engineers can understand the
issue.
Line 1408:
Line 1409: bondings = {BONDING_NAME: dict(remove=True)}
Line 1410: status, msg = self.vdsm_net.setupNetworks({}, bondings, {})
Line 1411:
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes