Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
......................................................................
Patch Set 10: Code-Review-1
(2 comments)
sorry, I miss few update rounds. Not currently happy with the current form, we need some
minor changes.
https://gerrit.ovirt.org/#/c/63748/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS10, Line 2601: getIoTuneResponse
we don't want anymore to build response objects in the API layer (see topic:wrapapi).
Unfortunately this goes in the wrong direction.
The best solution would be:
1. post a new patch to move the handling of responses for the existing methods getIoTune
and getIoTunePolicy in API.py
2. rebase this patch on top of that one
3. if needed, change this patch accordingly.
PS10, Line 2628: logger
the vm field is named "log", so it should be
self.log.error("noVM")
I still don't see a real benefit for this, but it is not harmful either, so let's
keep it
--
To view, visit
https://gerrit.ovirt.org/63748
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes