Dan Kenigsberg has posted comments on this change.
Change subject: BZ#842948: _removeFile() safe delete Node file
......................................................................
Patch Set 4: I would prefer that you didn't submit this
we cannot change the (somewhat bizarre) semantics of _removeFile. It intentionally removes
only the ramdisk file, leaving the persistent copy behind.
If you want to remove a network persistently, you have to start with delNetwork; to
persist this, call vdsm-store-net-config, or use ovirt_safe_delete_config directly.
--
To view, visit
http://gerrit.ovirt.org/6634
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e9b00ee4a38ebe7d5011e36bd9d3f7362cf26cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>