From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: rpmlint: clean non-executable-script
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/69348/1/tests/Makefile.am
File tests/Makefile.am:
PS1, Line 358:
where is testValidation.py?
It is under dist_vdsmtests_PYTHON.
It should be ONLY there, since it does not need to be executable.
https://gerrit.ovirt.org/#/c/69348/1/vdsm/virt/Makefile.am
File vdsm/virt/Makefile.am:
PS1, Line 31:
what happened to the hook?
it should be ONLY and executable (it
is never imported) and should be deployed ONLY under /usr/libexec/vdsm.
--
To view, visit
https://gerrit.ovirt.org/69348
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b2ccc1157880b75286097f0c2623616779f0113
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes