Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/47637/2//COMMIT_MSG
Commit Message:
Line 7: xmlrpc: retry when flushing socket
Line 8:
Line 9: m2crypto requires retry of write and we need to make sure that we do it once
Line 10: flushing data before closing a socket. In order to do so we need to move
Line 11: original implementation to our code base.
can you specify where is the original code exactly ?
Line 12:
Line 13:
Line 14: Bug-Url:
https://bugzilla.redhat.com/1261255
Line 15: Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
https://gerrit.ovirt.org/#/c/47637/2/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:
Line 287
Line 288
Line 289
Line 290
Line 291
what did this call do? we don't need it anymore?
--
To view, visit
https://gerrit.ovirt.org/47637
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes