Royce Lv has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File vdsm/supervdsm.py
Line 52: except:
For exception raised inside svdsm function I think we should not kill vdsm, will change
here
Line 53: os.unlink(ADDRESS)
You're right, even if svdsm has not clean up when exit, it will cleaned when restart,
it's redundent
Line 54: os.kill(os.getpid(), signal.SIGTERM)
The vdsm has signal handler:
def sigtermHandler(signum, frame):
if cif:
cif.prepareForShutdown()
if cif and cif.irs:
cif.irs.spmStop(cif.irs.getConnectedStoragePoolsList()['poollist'][0])
signal.signal(signal.SIGTERM, sigtermHandler)
That is why I choose to just send a signal to vdsm:)
....................................................
File vdsm/vdsm
Line 80: return
I will add test cases for all of start,restart and so on:)I thought non-root would fail
later, but here is better
--
To view, visit
http://gerrit.ovirt.org/4145
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>