Change in vdsm[master]: BZ#815825: backup certs during registration

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#815825: backup certs during registration
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1418: def _nodeBackupCerts(certs):
why are you using a dict instead of a plain list? do you need anything but the filename to
be backed up?

Line 1423:         if "cacert.pem" in certs[pemFile]:
how about something like

  dirname() + timeReplace + '_' + os.path.basename(path)

--
To view, visit http://gerrit.ovirt.org/3883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;