Adam Litke has posted comments on this change.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 659: tag = None
This could do with a comment. vdsClient would like to have getAllTasksInfo return _all_
tasks (not the filtered list that engine wants). In order to do that it must pass None
which is not allowed by our current xmlrpc configuration. So what this does is allow any
expression that evaluates to False: '' or False specifically to trigger the
behavior. It makes sense that the string "" should imply no filtering.
Does it make sense now?
....................................................
File vdsm_cli/vdsClient.py
Line 1107: tag = ''
I am not really sure what you mean here. Could you explain in a little more detail.
--
To view, visit
http://gerrit.ovirt.org/3613
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>