Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm/alignmentScan.py Line 27: cmd.extend(args) these two can be joined in a single line: ['...'] + args
Line 48: out_list = [(a[0], a[1], a[2], " ".join(a[3:])) for a in out_list] Besides not replacing all whitespace to single spaces and a list instead of tuple this is equal, but more efficient:
out_list = [line.split(None, 3) for line in out]
.................................................... File vdsm/alignmentScan_test.py Line 51: img = tempfile.mkstemp()[1] I prefer `with tempfile.NamedTemporaryFile() as f` since you don't need to worry about removing it.
-- To view, visit http://gerrit.ovirt.org/2916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saša Tomić tomic80@gmail.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saša Tomić tomic80@gmail.com