Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in
'addIscsiPortal'
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/iscsi.py
Line 181: portalStr = "%s:%d" % (portal.hostname, portal.port)
Line 182:
Line 183: with _iscsiadmTransactionLock:
Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr)
Line 185:
When you move a host to maintenance then that calls disconnectStorageServer which should
remove this definition so in general this shouldn't affect anything negatively. The
case where this would remain is in case of an error flow where for some reason it
wasn't disconnected properly or something. Even if that happens, it's not that
interesting as a few leftover connections shouldn't affect the host negatively (think
about FC where the host is always connected).
The advantage is that most of the time (since hosts don't move between DCs very often)
the host would automatically reconnect whenever it reboots (e.g. due to sanlock fencing)
and it would be available to engine almost immediately reducing recovery time. Imo that
is more important.
See oVirt Bug 881941 - After a reboot of both engine and vdsm domains take a long time (15
minutes) to recover
Line 186: try:
Line 187: # Push credentials
Line 188: if credentials is not None:
Line 189: for key, value in credentials.getIscsiadmOptions():
--
To view, visit
http://gerrit.ovirt.org/17212
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server