Change in vdsm[master]: Pass the Scheduler instance to HSM

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: Pass the Scheduler instance to HSM
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61253/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 395:     def ready(self):
Line 396:         return self._ready
Line 397: 
Line 398:     def set_scheduler(self, scheduler):
Line 399:         self._scheduler = scheduler
Why not pass the scheduler as argument to __init__?

I don't see a need to replace the scheduler during runtime, and this setter cannot be
used since we wrap this object in a dispatcher.
Line 400: 
Line 401:     @public
Line 402:     def registerDomainStateChangeCallback(self, callbackFunc):
Line 403:         """


-- 
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0db5a0dd3f519737a554550efb785d8099d02a6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes