Francesco Romani has posted comments on this change.
Change subject: v2v: filter out Xen VMs with block storage
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Let's just use one way to identify Xen (please see inline comments). Otherwise seems
fine.
https://gerrit.ovirt.org/#/c/62368/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 901: '''
Line 902: Currently we do not support importing VMs with block device from
Line 903: Xen on Rhel 5.x
Line 904: '''
Line 905: if conn.getURI().startswith(_XEN_SSH_PROTOCOL):
elsewhere below we are using
if conn.getType() == 'Xen':
could we use just one way to detect Xen? I can't tell which way is better, but we need
to use only one.
Line 906: return len(root.findall('.//disk[@type="block"]')) ==
0
Line 907: return True
Line 908:
Line 909:
--
To view, visit
https://gerrit.ovirt.org/62368
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes