Adam Litke has posted comments on this change.
Change subject: [WIP] Add ballooning support
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Looks pretty good. Just a few minor comments/improvements to look at.
....................................................
Commit Message
Line 10: Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Please add a more descriptive commit message. You should fully describe the semantics of
the new API you are planning to add including parameters, return values, and semantics.
....................................................
File vdsm/libvirtvm.py
Line 2110: return self._dom.info()[1:3]
Why oh why didn't libvirt present the domain info as a dictionary? In vdsm, we can do
a better job. Rather than returning an array slice, please create a dictionary and return
each of these values with meaningful key names.
--
To view, visit
http://gerrit.ovirt.org/3669
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>