Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/21772/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 106:                                                                conf_prefix,
Line 107:                                                                conf_suffix)
Line 108:             except OSError, e:
Line 109:                 if e.errno != os.errno.EEXIST:
Line 110:                     raise
>  Not sure what you mean here. 
should be:

 if os.path.exists(xxx):
     super(...).removeConf()
Line 111: 
Line 112:         utils.rmFile(P_SYSTEMCTL_CONF)
Line 113: 
Line 114:     def _exec_libvirt_configure(self, action):


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes