Change in vdsm[master]: clientIF: Fix use of getConfDevices
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 454: try:
Line 455: # Do not prepare volumes when system goes down
Line 456: if self._enabled:
Line 457: vmObj.preparePaths(
Line 458: vmObj.buildConfDevices()[vm.DISK_DEVICES])
(Not related to Yeela's fix) Is there anything better than using two internal (imo)
calls from here? I am sure we're already doing something similar inside the Vm object.
Can we refactor/group and reuse the same method?
Line 459: except:
Line 460: self.log.error("Vm %s recovery failed",
Line 461: vmId, exc_info=True)
Line 462: except:
--
To view, visit http://gerrit.ovirt.org/21832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes